Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: enable pubsub via config file and enabled by default #2427

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Sep 4, 2019

BREAKING CHANGE: pubsub is now enabled by default and the experimental flag was removed

As discussed, we will remove the pubsub flags from the js daemon and will use the config as the way to disable it (will be enabled by default now!)

Needs:

Reference:

@vasco-santos vasco-santos force-pushed the feat/enable-pubsub-via-config branch 2 times, most recently from cbe4919 to 283e1ad Compare September 4, 2019 16:54
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vasco-santos and others added 2 commits September 5, 2019 14:33
BREAKING CHANGE:pubsub is now enabled by default and the experimental flag was removed
@vasco-santos vasco-santos force-pushed the feat/enable-pubsub-via-config branch from ba50a58 to db8866c Compare September 5, 2019 12:34
@alanshaw alanshaw merged commit 27751cf into master Sep 5, 2019
@alanshaw alanshaw deleted the feat/enable-pubsub-via-config branch September 5, 2019 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants